Forbid protobuf 4.x in requirements #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
- Coverage 86.42% 86.28% -0.14%
==========================================
Files 81 81
Lines 7919 7919
==========================================
- Hits 6844 6833 -11
- Misses 1075 1086 +11
|
mryab
changed the title
mryab
approved these changes
Sep 28, 2022
mryab
pushed a commit
that referenced
this pull request
Oct 19, 2022
forbid protobuf 4.x for now (cherry picked from commit e9f35b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that newer versions of protobuf (starting from 4.0) are incompatible with hivemind: more specifically, these versions prevent CI from passing. As a temporary solution, this PR constrains the version of protobuf to be smaller than 4.0.0.