use_local_updates in optimizer #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artek0chumak
approved these changes
May 17, 2022
|
[merging once all tests pass] |
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 83.12% 83.71% +0.58%
==========================================
Files 81 81
Lines 8061 8063 +2
==========================================
+ Hits 6701 6750 +49
+ Misses 1360 1313 -47
|
mryab
approved these changes
May 17, 2022
tests/test_optimizer.py
Outdated
| assert not optimizer.tracker.is_alive() | ||
| assert optimizer.grad_averager is None if use_local_updates else (not optimizer.grad_averager.is_alive()) |
There was a problem hiding this comment.
Better to split the conditional in multiple lines:
tests/test_optimizer.py
Outdated
| assert not optimizer.tracker.is_alive() | ||
| assert optimizer.grad_averager is None if use_local_updates else (not optimizer.grad_averager.is_alive()) |
There was a problem hiding this comment.
Suggested change
| assert optimizer.grad_averager is None if use_local_updates else (not optimizer.grad_averager.is_alive()) | |
| if use_local_updates: | |
| assert optimizer.grad_averager is None | |
| else: | |
| assert not optimizer.grad_averager.is_alive() |
There was a problem hiding this comment.
[implemented it as requested, but did not notice the suggestion
tests/test_optimizer.py
Outdated
Comment on lines
310
to
316
| ( | ||
| True, | ||
| True, | ||
| False, | ||
| False, | ||
| False, | ||
| ), |
There was a problem hiding this comment.
To make formatting more consistent, you can surround the entire block of cases above with # fmt: off and # fmt: on
There was a problem hiding this comment.
did as requested, thx for suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[this PR fixes some edge case bugs introduced since 1.1.0, those bugs do not affect pip version]