Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pytest version in requirements-dev, use file_descriptor in tests #454

Merged
merged 17 commits into from
Feb 9, 2022

Conversation

justheuristic
Copy link
Member

@justheuristic justheuristic commented Feb 8, 2022

This fixes the "previous item was not torn down properly" error in CI.

pytest-dev/pytest#9621

@justheuristic justheuristic requested a review from mryab February 8, 2022 22:43
@mryab mryab changed the title Investigate "previous item was not torn down properly" Pin pytest version in requirements-dev Feb 8, 2022
@justheuristic justheuristic changed the title Pin pytest version in requirements-dev Pin pytest version in requirements-dev, use file_descriptor by default Feb 8, 2022
@mryab mryab changed the title Pin pytest version in requirements-dev, use file_descriptor by default Pin pytest version in requirements-dev, use file_descriptor in tests Feb 9, 2022
@mryab mryab self-requested a review February 9, 2022 08:54
@justheuristic
Copy link
Member Author

justheuristic commented Feb 9, 2022

(copied from discord)

  • tests failing was not just random, there was a pattern to it

  • pytest failed specifically with codecov enabled - you can see it consistently failed in 5 last failed builds
    image

  • and it failed specifically on test_mode -> remote_call_many

Here's a proof: removing codecov fixes the issue https://github.com/learning-at-home/hivemind/runs/5124226685?check_suite_focus=true
I'm now investigating if this is fixed by pinning codecov version to be compatible to that pytest

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #454 (8999dd9) into master (2abda6f) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   84.01%   84.05%   +0.03%     
==========================================
  Files          78       78              
  Lines        7932     7932              
==========================================
+ Hits         6664     6667       +3     
+ Misses       1268     1265       -3     
Impacted Files Coverage Δ
hivemind/averaging/matchmaking.py 87.50% <0.00%> (ø)
hivemind/averaging/averager.py 88.37% <0.00%> (+0.72%) ⬆️

@mryab
Copy link
Member

mryab commented Feb 9, 2022

To conclude, the CI failures for the pytest/codecov jobs are related to pytest-dev/pytest#9621 and pytest-dev/pytest-cov#520; adding these issues here to have backlinks to this PR in their discussion threads

@justheuristic justheuristic merged commit 0959dfb into master Feb 9, 2022
@justheuristic justheuristic deleted the investigate-ci branch February 9, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants