Move hivemind.Server from init, streamline imports #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d765c5d.
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 83.75% 83.99% +0.24%
==========================================
Files 77 78 +1
Lines 7927 7928 +1
==========================================
+ Hits 6639 6659 +20
+ Misses 1288 1269 -19
|
mryab
commented
Jan 8, 2022
| A working server does 3 things: | ||
| - processes incoming forward/backward requests via Runtime (created by the server) | ||
| - publishes updates to expert status every :update_period: seconds | ||
| - follows orders from HivemindController - if it exists |
There was a problem hiding this comment.
I guess this was something that we planned to implement, but never did. Stumbled upon it by pure chance
There was a problem hiding this comment.
Curiously, the doc statement is still technically correct :D
class VorpalSword(SwordBase):
"""A special sword used to kill Jabberwocky - if it exists"""As far as I remember, this was my wishful thinking. The idea was for HivemindController to be a class that can change server config over time: add or remove experts, change hyperparameters, stuff like that...
Makes me think how many of these lost dreams we still have in other docstrings :)
justheuristic
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a chore PR that mainly moves hivemind.Server and related functions into a separate file to keep
server/__init__.pysimple and avoid exposing unintended methods at the top level of the library.Also, I replaced broad
import hivemindstatements with more specific ones in relevant parts of the project to narrow down their scope and avoid possible circular imports in the future.Finally, I moved
generate_uids_from_patterntoserver.py, since the refactoring from the first step exposed a circular dependency in the module. This can be improved in the future via better encapsulation of ExpertUID (right now its constants are used all overhivemind.moe); for now, I believe the solution with a private function is fine.