Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing dots in log messages and errors #419

Merged
merged 4 commits into from
Dec 4, 2021
Merged

Conversation

borzunov
Copy link
Member

@borzunov borzunov commented Dec 2, 2021

This is important to make the output consistent.

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #419 (beb7d69) into master (c328698) will increase coverage by 0.19%.
The diff coverage is 37.03%.

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   83.49%   83.68%   +0.19%     
==========================================
  Files          77       77              
  Lines        7790     7790              
==========================================
+ Hits         6504     6519      +15     
+ Misses       1286     1271      -15     
Impacted Files Coverage Δ
hivemind/averaging/allreduce.py 79.06% <0.00%> (ø)
hivemind/averaging/control.py 94.17% <0.00%> (ø)
hivemind/averaging/load_balancing.py 95.91% <0.00%> (ø)
hivemind/averaging/partition.py 98.01% <0.00%> (ø)
hivemind/dht/dht.py 89.87% <0.00%> (ø)
hivemind/dht/routing.py 94.11% <0.00%> (ø)
hivemind/hivemind_cli/run_server.py 0.00% <ø> (ø)
hivemind/moe/client/moe.py 92.82% <0.00%> (ø)
hivemind/optim/collaborative.py 23.64% <0.00%> (ø)
hivemind/optim/experimental/state_averager.py 86.86% <0.00%> (ø)
... and 16 more

Copy link
Member

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was in the wrong for not removing them in the first place.

@borzunov borzunov merged commit 12099ce into master Dec 4, 2021
@borzunov borzunov deleted the remove-dots branch December 4, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants