Do not log caller for INFO messages #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
==========================================
+ Coverage 83.42% 83.68% +0.25%
==========================================
Files 77 77
Lines 7790 7795 +5
==========================================
+ Hits 6499 6523 +24
+ Misses 1291 1272 -19
|
borzunov
force-pushed
the
hide-caller-for-info
branch
from
db0ae23 to
ea40b98
Compare
borzunov
commented
Dec 2, 2021
| @@ -461,7 +461,7 @@ def _update_global_epoch(self, grad_scaler: Optional[GradScaler]) -> None: | |||
| if not self.client_mode: | |||
| self.grad_averager.state_sharing_priority = self.local_epoch | |||
|
|
|||
| logger.log(self.status_loglevel, f"Transitioning to epoch {self.local_epoch}.") | |||
| logger.debug(f"Transitioning to epoch {self.local_epoch}") | |||
There was a problem hiding this comment.
This duplicates the Step N message (see the "After" screenshot).
There was a problem hiding this comment.
This message is useful because
- it signifies when a (potentially long) optimizer step is finished
- it is the only message that will be printed when use_local_updates=True (i.e. there is no global step)
justheuristic
approved these changes
Dec 2, 2021
borzunov
force-pushed
the
hide-caller-for-info
branch
from
e1c3cd4 to
ea40b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caller info for INFO log messages is often long but rarely useful. Such long lines confuse new users.
This PR hides the caller info for INFO messages only, unless a user specifies env variable
HIVEMIND_ALWAYS_LOG_CALLER=True(Trueis case-insensitive).I think it is important that this behavior does not depend on
HIVEMIND_LOGLEVEL. Example: a user could create a Colab notebook parsing the logs and change theHIVEMIND_LOGLEVELin the last minute, thus breaking the parser (since the INFO messages start to have the other format).Before:
After: