Fix minor issues in documentation #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
commented
Oct 13, 2021
borzunov
commented
Oct 13, 2021
borzunov
force-pushed
the
refer-to-discord-in-docs
branch
from
5b767fe to
eb8e8fe
Compare
borzunov
force-pushed
the
refer-to-discord-in-docs
branch
from
eb8e8fe to
3a0b788
Compare
mryab
reviewed
Oct 13, 2021
borzunov
force-pushed
the
refer-to-discord-in-docs
branch
from
18bdc79 to
b436ced
Compare
borzunov
commented
Oct 13, 2021
| @misc{hivemind, | ||
| author = {Learning@home team}, | ||
| author = {Learning{@}home team}, |
There was a problem hiding this comment.
Suggested change
| author = {Learning{@}home team}, | |
| author = {Learning{@}home team}, |
The syntax highlighting is not okay with @ without the curly braces. This may mean that it may be displayed incorrectly IRL as well.
The {@} is displayed fine (just checked it in Overleaf).
borzunov
force-pushed
the
refer-to-discord-in-docs
branch
from
0e12947 to
e376255
Compare
borzunov
commented
Oct 13, 2021
| url = {https://proceedings.neurips.cc/paper/2020/file/25ddc0f8c9d3e22e03d3076f98d83cb2-Paper.pdf}, | ||
| volume = {33}, | ||
| year = {2020} | ||
| author = {Ryabinin, Max and Gusev, Anton}, |
There was a problem hiding this comment.
The changes here and below make bibtex formatting consistent across all 5 references.
borzunov
changed the title
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
=======================================
Coverage 83.39% 83.39%
=======================================
Files 71 71
Lines 6497 6497
=======================================
Hits 5418 5418
Misses 1079 1079
|
justheuristic
approved these changes
Oct 14, 2021
README.md
Outdated
| To learn more about the ideas behind this library, see https://learning-at-home.github.io or read | ||
| the [NeurIPS 2020 paper](https://arxiv.org/abs/2002.04013). | ||
| To learn more about the ideas behind this library, | ||
| see the [full list](https://github.com/learning-at-home/hivemind/tree/refer-to-discord-in-docs#citation) of our papers. |
There was a problem hiding this comment.
Suggested change
| see the [full list](https://github.com/learning-at-home/hivemind/tree/refer-to-discord-in-docs#citation) of our papers. | |
| see the [list](https://github.com/learning-at-home/hivemind/tree/refer-to-discord-in-docs#citation) of our papers. |
[nit] i find the "full" part unnecessary and not necessarily true
There was a problem hiding this comment.
The links to the papers above this text form some kind of a list as well :) That's why I refer the list below as the "full list".
mryab
approved these changes
Oct 14, 2021
borzunov
force-pushed
the
refer-to-discord-in-docs
branch
from
e5e3d1d to
43689f8
Compare
borzunov
force-pushed
the
refer-to-discord-in-docs
branch
from
43689f8 to
9f2b397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.