Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arguments with default values from example instructions #388

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

borzunov
Copy link
Member

This PR removes arguments with default values from example instructions to make the commands less frightening.

@borzunov borzunov added the documentation Improvements or additions to documentation label Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #388 (7505c8a) into master (b442369) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   84.06%   83.81%   -0.25%     
==========================================
  Files          70       70              
  Lines        6426     6426              
==========================================
- Hits         5402     5386      -16     
- Misses       1024     1040      +16     
Impacted Files Coverage Δ
hivemind/averaging/matchmaking.py 77.50% <0.00%> (-6.57%) ⬇️
hivemind/dht/node.py 92.63% <0.00%> (+1.18%) ⬆️

@borzunov borzunov merged commit d809e30 into master Sep 21, 2021
@borzunov borzunov deleted the no-default-values branch September 21, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants