Use ModeClient in libp2p DHT in case of --client_mode #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
changed the title
borzunov
force-pushed
the
dht-mode-auto
branch
from
a4d5e16 to
c61c9d5
Compare
justheuristic
approved these changes
Sep 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
==========================================
- Coverage 83.44% 83.38% -0.06%
==========================================
Files 66 66
Lines 6124 6126 +2
==========================================
- Hits 5110 5108 -2
- Misses 1014 1018 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See docs for the DHT modes.
I hypothesize that having
ModeServereven on unreachable nodes could harm various libp2p features such as the NAT traversal.