Prefetch while reading rpc_aggregate_part() outputs #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 83.48% 83.47% -0.01%
==========================================
Files 66 66
Lines 6126 6124 -2
==========================================
- Hits 5114 5112 -2
Misses 1012 1012
|
borzunov
force-pushed
the
more-prefetch
branch
2 times, most recently
from
1d8c2ee to
218001a
Compare
borzunov
commented
Aug 30, 2021
justheuristic
approved these changes
Aug 31, 2021
borzunov
force-pushed
the
more-prefetch
branch
from
218001a to
1a82b01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rpc_aggregate_part() does not receive output parts and decompress them in parallel. This PR fixes it.
Future work:
iterate_protobuf_handler()instead.