Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logger warning in P2P #361

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Fix logger warning in P2P #361

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c65ab28
fix warning in contol.py
dvmazur Aug 24, 2021
1352a01
fix debug statement
dvmazur Aug 24, 2021
7e30d47
Merge branch 'master' into fix-warnings
dvmazur Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hivemind/p2p/p2p_daemon_bindings/control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ async def _read_from_persistent_conn(self, reader: asyncio.StreamReader):
remote_exc = P2PHandlerError(resp.callUnaryResponse.error.decode(errors="ignore"))
self._pending_calls[call_id].set_exception(remote_exc)
else:
logger.debug("received unexpected unary call:", resp)
logger.debug(f"Received unexpected unary call: {resp}")

elif resp.HasField("requestHandling"):
handler_task = asyncio.create_task(self._handle_persistent_request(call_id, resp.requestHandling))
Expand All @@ -186,7 +186,7 @@ async def _read_from_persistent_conn(self, reader: asyncio.StreamReader):
self._pending_calls[call_id].set_result(None)

else:
logger.warning("Received unexpected response from daemon:", resp)
logger.warning(f"Received unexpected response from daemon: {resp}")

async def _write_to_persistent_conn(self, writer: asyncio.StreamWriter):
with closing(writer):
Expand Down