Fix minor asyncio issues in averager #356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes minor asyncio issues in averager found while debugging #351:
Make averager not fail during reporting an error if the recipient closes the connection before receiving it (e.g. if it has crashed itself). Example:
Support asyncio cancellation and shutdown in
_load_state_from_peers
, that is don't suppressasyncio.CancelledError
andGeneratorExit
. For example, this happens whenGeneratorExit
is suppressed:Remove excess calls of
__aiter__()
/__anext__()
(outsidehivemind.utils.asyncio
, we can always manage withanext()
, so let's not scare the code readers with these magic methods)