Propagate startup errors from DHT and averager processes #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justheuristic
approved these changes
Aug 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 83.39% 83.33% -0.07%
==========================================
Files 66 66
Lines 5973 5987 +14
==========================================
+ Hits 4981 4989 +8
- Misses 992 998 +6
|
borzunov
force-pushed
the
ready-is-mpfuture
branch
3 times, most recently
from
f4b1e54 to
ded9905
Compare
borzunov
force-pushed
the
ready-is-mpfuture
branch
from
ded9905 to
51764f6
Compare
borzunov
force-pushed
the
ready-is-mpfuture
branch
from
1f02351 to
dc25ff3
Compare
mryab
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, startup failure of DHT and/or averager (e.g. when
initial_peersare unreachable) leads to a deadlock in the parent process. The exception message is printed to stdout but the parent process does not stop, and this is not nice for tests and end users.This PR makes startup errors to be propagated to the parent process.