Speed up P2P client creation #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 83.33% 83.40% +0.07%
==========================================
Files 66 66
Lines 5977 5973 -4
==========================================
+ Hits 4981 4982 +1
+ Misses 996 991 -5
|
borzunov
reviewed
Aug 2, 2021
|
Fantastic results! 🚀 One more thing to check is how the daemon behave in case of incorrect arguments. Ideally, we'd like to capture the daemon's stderr, read the error message, and convert it to a Python error with this message. |
Co-authored-by: Alexander Borzunov <[email protected]>
borzunov
reviewed
Aug 3, 2021
| self._listen_task = None | ||
| self._server_stopped = asyncio.Event() |
There was a problem hiding this comment.
This event is redundant, we can just cancel self._listen_task.
borzunov
reviewed
Aug 3, 2021
|
|
||
| self._listen_task = asyncio.create_task(listen()) | ||
|
|
||
| async def _stop_listening(self) -> None: |
There was a problem hiding this comment.
Cancelling self._listen_task is enough here. The corresponding code moved to self._terminate() (since it is not async anymore).
justheuristic
approved these changes
Aug 3, 2021
borzunov
approved these changes
Aug 3, 2021
This was referenced Aug 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #300 and speeds up the creation of P2P clients by reading the daemon's stdout instead of pinging it repeatedly.
This optimization speeds up running the tests by 35% locally. Here are the benchmarks:
