Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce complexity of several DHT tests #334

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Conversation

justheuristic
Copy link
Member

  • test averaging previously ran with 3 different part sizes in all 8 scenarios, now it uses default part size and only changes it in one (most complex) scenario
  • test_dht_node now has reduced number of peers, but also reduced bucket size
  • test_dht_node runs more find attempts for stability

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #334 (7052c5c) into master (0d67284) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   82.22%   82.17%   -0.06%     
==========================================
  Files          66       66              
  Lines        5987     5987              
==========================================
- Hits         4923     4920       -3     
- Misses       1064     1067       +3     
Impacted Files Coverage Δ
hivemind/averaging/key_manager.py 95.45% <0.00%> (-2.28%) ⬇️
hivemind/averaging/matchmaking.py 76.75% <0.00%> (-0.62%) ⬇️
hivemind/utils/timed_storage.py 96.93% <0.00%> (+1.02%) ⬆️

@mryab mryab changed the title Reduce complexity of some tests Reduce complexity of several DHT tests Jul 23, 2021
@justheuristic justheuristic requested a review from yhn112 July 23, 2021 17:49
@justheuristic justheuristic merged commit 39afa97 into master Jul 23, 2021
@justheuristic justheuristic deleted the minimize-long-tests branch July 23, 2021 18:02
This was referenced Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants