Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shared memory from MPFuture, fix minor bugs #317

Merged
merged 26 commits into from
Jul 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4248a91
fix "coroutine was never awaited"
justheuristic Jul 11, 2021
c2ce35c
client-server-style MPFuture
justheuristic Jul 13, 2021
a310f26
Merge branch 'master' into make-mpfuture-great-again
justheuristic Jul 13, 2021
5321f7f
re-black
justheuristic Jul 13, 2021
904c808
re-black
justheuristic Jul 13, 2021
34e2d1d
py39 compat
justheuristic Jul 13, 2021
0e38f5d
py39 compat
justheuristic Jul 13, 2021
1849fe2
Merge branch 'master' into make-mpfuture-great-again
justheuristic Jul 13, 2021
668698d
review
borzunov Jul 13, 2021
ba2d0cd
Merge branch 'master' into make-mpfuture-great-again
justheuristic Jul 13, 2021
5d87238
make moe test easier
justheuristic Jul 13, 2021
7652a99
Update hivemind/utils/mpfuture.py
justheuristic Jul 13, 2021
e5fc179
Update hivemind/utils/mpfuture.py
justheuristic Jul 13, 2021
f5600c6
Update hivemind/utils/mpfuture.py
justheuristic Jul 13, 2021
9b563bb
Update hivemind/utils/mpfuture.py
justheuristic Jul 13, 2021
2dcd26d
Merge remote-tracking branch 'origin/make-mpfuture-great-again' into …
justheuristic Jul 13, 2021
bd852ef
make moe test easier
justheuristic Jul 13, 2021
d6a4048
review
borzunov Jul 13, 2021
f95a00a
review
borzunov Jul 13, 2021
d564efc
review
borzunov Jul 13, 2021
1667264
review
borzunov Jul 13, 2021
8a01bf1
review
justheuristic Jul 13, 2021
1a4d7a8
review
borzunov Jul 13, 2021
ad34fdf
Update hivemind/utils/mpfuture.py
justheuristic Jul 13, 2021
3ee5732
review
justheuristic Jul 13, 2021
f147d18
Merge remote-tracking branch 'origin/make-mpfuture-great-again' into …
justheuristic Jul 13, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hivemind/moe/server/task_pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def __init__(

def submit_task(self, *args: torch.Tensor) -> Future:
"""Add task to this pool's queue, return Future for its output"""
task = Task(MPFuture(), args)
task = Task(MPFuture(synchronize=False), args)
if self.get_task_size(task) > self.max_batch_size:
exc = ValueError(f"Task size greater than max_batch_size ({self.max_batch_size}), it can't be processed")
task.future.set_exception(exc)
Expand Down
Loading