Simplify argument parsing, update docs in ALBERT example #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mryab
changed the title
mryab
commented
Jul 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 82.06% 82.06%
=======================================
Files 66 66
Lines 5898 5898
=======================================
Hits 4840 4840
Misses 1058 1058
|
mryab
commented
Jul 11, 2021
| current_step = latest_step | ||
| alive_peers = 0 | ||
| num_batches = 0 |
justheuristic
approved these changes
Jul 12, 2021
|
Beautiful |
Co-authored-by: justheuristic <[email protected]>
yhn112
approved these changes
Jul 13, 2021
Co-authored-by: Michael Diskin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation in the ALBERT examples to replace all mentions of "the coordinator" with "the training monitor" after #308. Also, the argument parsing logic in
run_trainer.pyis refactored to avoid the current convoluted and error-prone solution of "convert all arguments to a dictionary - pop the arguments you do not need - pass all of the rest to the optimizer". Finally, it contains minor changes in the guide/docstrings meant to improve their clarity.