Split hivemind.client into hivemind.averaging and hivemind.moe #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 81.63% 82.05% +0.41%
==========================================
Files 63 65 +2
Lines 5866 5856 -10
==========================================
+ Hits 4789 4805 +16
+ Misses 1077 1051 -26
|
justheuristic
approved these changes
Jul 3, 2021
There was a problem hiding this comment.
LGTM
Please fix the docs before merging (see comment) (already fixed)
If you have no strong preferences, let's merge #298 ahead of this this
yhn112
approved these changes
Jul 3, 2021
# Conflicts: # benchmarks/benchmark_dht.py # benchmarks/benchmark_throughput.py # hivemind/averaging/training.py # hivemind/hivemind_cli/run_server.py
justheuristic
approved these changes
Jul 3, 2021
justheuristic
approved these changes
Jul 3, 2021
yhn112
approved these changes
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the hivemind.client module, since it contains two different functionalities: Mixture-of-Experts client code and decentralized averaging. To properly separate the responsibilities of these classes, I moved them to hivemind.averaging and hivemind.moe (also putting the server under the same directory).
Also, to prepare for #275, I slightly removed the number of wildcard imports and modules with class definitions in
__init__