Remove use of packaging module to avoid installation errors #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
setup.py
usespackaging
module to parse Golang versions. This leads to errors in case of installing hivemind to a clean Python installation, sincepackaging
is not a part ofsetuptools
and is not installed by default.#269 attempted to fix that, however this fix has no effect since the
packaging
module is imported in the beginning ofsetup.py
beforerequirements.txt
is even parsed.The problem can be easily reproduced by creating a new virtualenv environment and trying to install hivemind inside it with
pip install -e .[dev]
.This PR solves the problem by removing the usage of the
packaging
module completely.