Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of packaging module to avoid installation errors #284

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

borzunov
Copy link
Member

@borzunov borzunov commented Jun 19, 2021

Currently, setup.py uses packaging module to parse Golang versions. This leads to errors in case of installing hivemind to a clean Python installation, since packaging is not a part of setuptools and is not installed by default.

#269 attempted to fix that, however this fix has no effect since the packaging module is imported in the beginning of setup.py before requirements.txt is even parsed.

The problem can be easily reproduced by creating a new virtualenv environment and trying to install hivemind inside it with pip install -e .[dev].

This PR solves the problem by removing the usage of the packaging module completely.

@borzunov borzunov added the bug Something isn't working label Jun 19, 2021
@borzunov borzunov requested review from mryab and dvmazur June 19, 2021 01:52
@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #284 (180db82) into master (ef2c6ab) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   72.25%   72.34%   +0.08%     
==========================================
  Files          62       62              
  Lines        5594     5594              
==========================================
+ Hits         4042     4047       +5     
+ Misses       1552     1547       -5     
Impacted Files Coverage Δ
hivemind/dht/node.py 93.23% <0.00%> (+1.25%) ⬆️

@borzunov borzunov merged commit b6fbae4 into master Jun 19, 2021
@borzunov borzunov deleted the remove-packaging branch June 19, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants