Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loss metric calculation #240

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Fix loss metric calculation #240

merged 1 commit into from
Apr 21, 2021

Conversation

yhn112
Copy link
Member

@yhn112 yhn112 commented Apr 21, 2021

No description provided.

@yhn112 yhn112 requested a review from justheuristic April 21, 2021 15:00
justheuristic
justheuristic approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yhn112 yhn112 merged commit 2314e7e into master Apr 21, 2021
@yhn112 yhn112 deleted the fix_metrics branch April 21, 2021 15:09
borzunov added a commit that referenced this pull request May 18, 2021
@borzunov
Log correct loss in examples/albert/run_first_peer.py (#265)
9bb775f 
#240 changed the formula for the current loss, but it was not changed in the `logger.info` call. Therefore, the coordinator now logs inadequate loss values.
@elricwan elricwan mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justheuristic justheuristic justheuristic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhn112 @justheuristic