Disentangle DecentralizedAverager components, add weights #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@foksly if you have time, pls review this as well. |
mryab
requested changes
Apr 10, 2021
| return AllReduceRunner(group_id=group_info.group_id, tensors=averaged_tensors, endpoint=self.endpoint, | ||
| ordered_group_endpoints=group_info.endpoints, part_sizes=part_sizes, | ||
| weights=weights, gathered=user_gathered, return_deltas=True, **kwargs) | ||
| except Exception as e: |
There was a problem hiding this comment.
It's best to catch a more specific exception
There was a problem hiding this comment.
This code was intentionally written to catch all kinds of fails
including, but not limited to
- malformed metadata
- serialization errors
- negative throughputs
- unsolvable load_balancing
- your endpoint is not in group
- some endpoint is present multiple times
- AssertionError
[Resolution: let's keep it as is for now]
mryab
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the internal logic of DecentralizedAverager to make matchmaking code independent of allreduce and vice versa.