Added Greeting Functions #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let scuberGreeting | ||
| if(rideDistance <= 400){ | ||
| scuberGreeting = 'This one is on me!' | ||
| }else if(rideDistance > 400 && rideDistance < 2000){ |
There was a problem hiding this comment.
You can exclude rideDistance > 400 && since it's already covered by the first part of the conditional.
Suggested change
| }else if(rideDistance > 400 && rideDistance < 2000){ | |
| }else if(rideDistance < 2000){ |
Comment on lines
+1
to
+12
| function scuberGreetingForFeet(rideDistance){ | ||
| let scuberGreeting | ||
| if(rideDistance <= 400){ | ||
| scuberGreeting = 'This one is on me!' | ||
| }else if(rideDistance > 400 && rideDistance < 2000){ | ||
| scuberGreeting ='That will be twenty bucks.' | ||
| }else if(rideDistance < 2500 && rideDistance > 2000){ | ||
| scuberGreeting = 'I will gladly take your thirty bucks.' | ||
| }else if (rideDistance > 2500){ | ||
| scuberGreeting = 'No can do.' | ||
| } | ||
| return scuberGreeting |
There was a problem hiding this comment.
I know it seems trivial, but consistent spacing that follows the "standards" is important for readability.
Suggested change
| function scuberGreetingForFeet(rideDistance){ | |
| let scuberGreeting | |
| if(rideDistance <= 400){ | |
| scuberGreeting = 'This one is on me!' | |
| }else if(rideDistance > 400 && rideDistance < 2000){ | |
| scuberGreeting ='That will be twenty bucks.' | |
| }else if(rideDistance < 2500 && rideDistance > 2000){ | |
| scuberGreeting = 'I will gladly take your thirty bucks.' | |
| }else if (rideDistance > 2500){ | |
| scuberGreeting = 'No can do.' | |
| } | |
| return scuberGreeting | |
| function scuberGreetingForFeet(rideDistance){ | |
| let scuberGreeting | |
| if (rideDistance <= 400) { | |
| scuberGreeting = 'This one is on me!' | |
| } else if (rideDistance > 400 && rideDistance < 2000) { | |
| scuberGreeting ='That will be twenty bucks.' | |
| } else if (rideDistance < 2500 && rideDistance > 2000) { | |
| scuberGreeting = 'I will gladly take your thirty bucks.' | |
| } else if (rideDistance > 2500) { | |
| scuberGreeting = 'No can do.' | |
| } | |
| return scuberGreeting |
Comment on lines
+20
to
+33
| let tipGreeting; | ||
| switch(tip){ | ||
| case 'generous' : | ||
| tipGreeting = 'Thank you so much.' | ||
| break; | ||
| case 'not as generous' : | ||
| tipGreeting = 'Thank you.' | ||
| break; | ||
| default: | ||
| tipGreeting = 'Bye.' | ||
| } | ||
| return tipGreeting | ||
| } |
There was a problem hiding this comment.
Here's an easy way to clean this up:
function switchOnCharmFromTip(tip){
switch(tip){
case 'generous':
return 'Thank you so much.'
case 'not as generous':
return 'Thank you.'
default:
return 'Bye.'
}| scuberGreeting ='That will be twenty bucks.' | ||
| }else if(rideDistance < 2500 && rideDistance > 2000){ | ||
| scuberGreeting = 'I will gladly take your thirty bucks.' | ||
| }else if (rideDistance > 2500){ |
There was a problem hiding this comment.
Same idea here... this isn't need since it's already covered.
Suggested change
| }else if (rideDistance > 2500){ | |
| } else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.