Complete Lab #16
Open
Complete Lab #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let result | ||
| if( number < 400 ) { | ||
| result = 'This one is on me!'; | ||
| } else if (number > 400 && number < 2000 ) { |
There was a problem hiding this comment.
You don't need to include the > 400 bit since the first part of the conditional covers that.
Suggested change
| } else if (number > 400 && number < 2000 ) { | |
| } else if (number < 2000 ) { |
| // Write your code here! | ||
| function scuberGreetingForFeet(number){ | ||
| let result | ||
| if( number < 400 ) { |
There was a problem hiding this comment.
Suggested change
| if( number < 400 ) { | |
| if (number < 400) { |
| result = 'That will be twenty bucks.'; | ||
| } else if (number >= 2001 && number < 2500 ) { | ||
| result = 'I will gladly take your thirty bucks.'; | ||
| } else if (number > 2500) { |
There was a problem hiding this comment.
Same idea here.
Suggested change
| } else if (number > 2500) { | |
| } else { |
Comment on lines
+16
to
+17
| const message = city === 'NYC' ? "Ok, sounds good." : "No go."; | ||
| return message; |
There was a problem hiding this comment.
While this works, you can simply return the ternary:
Suggested change
| const message = city === 'NYC' ? "Ok, sounds good." : "No go."; | |
| return message; | |
| return city === 'NYC' ? 'Ok, sounds good.' : 'No go.; |
Also, try to be consistent with using either single and double quotes, but not both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.