heartbeat challenge #258
Merged
heartbeat challenge #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good todos, worth extracting as separate issues |
troggy
reviewed
Dec 5, 2019
| // TODO: Is the signer we challenged still in control of the Slot? Depends on timeout-time (currently casChallangeDuration) at the least. | ||
| function respondBeat( | ||
| bytes32[] memory _inclusionProof, | ||
| bytes32[] memory _walkProof, |
There was a problem hiding this comment.
@TheReturnOfJan could you please more comments about what is walkProof ?
There was a problem hiding this comment.
@troggy new commit should be a bit clearer.
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
==========================================
- Coverage 75.77% 75.68% -0.09%
==========================================
Files 40 40
Lines 908 946 +38
Branches 207 219 +12
==========================================
+ Hits 688 716 +28
Misses 98 98
- Partials 122 132 +10
Continue to review full report at Codecov.
|
troggy
approved these changes
Dec 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #257