fix: remove simp from compare_self
#7218
Closed
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Feb 25, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 25, 2025
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
builds-mathlib
TwoFX
approved these changes
Feb 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This PR will be superseded by #7222, which also resolves some errors with more recent changes. @JovanGerb feel free to let me know if you would like to change something! (And thanks for proposing this very helpful change -- me creating a new PR doesn't mean that anything was wrong with this one.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
simptag fromcompare_self, becausesimptries this lemma at every subexpression.