fix: missing indents in Try this message #7191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only impacts the message, not the widget.
|
changelog-language |
github-actions
bot
added
changelog-language
|
Mathlib CI status (docs):
|
|
Thanks! Before merging: Did you make sure that it still looks correct in the InfoView in VSCode? (The rendering of message data sometimes differs between the info view and text output like this, and we certainly want to prioritize the InfoView display.) |
|
I believe the infoview is handled by |
eric-wieser
commented
Feb 25, 2025
| @@ -426,7 +426,7 @@ def addSuggestions (ref : Syntax) (suggestions : Array Suggestion) | |||
| (codeActionPrefix? : Option String := none) : MetaM Unit := do | |||
| if suggestions.isEmpty then throwErrorAt ref "no suggestions available" | |||
| let msgs := suggestions.map toMessageData | |||
| let msgs := msgs.foldl (init := MessageData.nil) (fun msg m => msg ++ m!"\n• " ++ m) | |||
| let msgs := msgs.foldl (init := MessageData.nil) (fun msg m => msg ++ m!"\n• " ++ .nest 2 m) | |||
| logInfoAt ref m!"{header}{msgs}" | |||
| addSuggestionCore ref suggestions header (isInline := false) origSpan? style? codeActionPrefix? | |||
There was a problem hiding this comment.
@nomeata: this line is the one that produces the widget, and it doesn't use msgs at all.
In fact I think the rendering of the widget is subtly wrong in an unrelated way, but arguably that's out of scope for this PR.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the indentation of "Try this" suggestions in widget-less multiline messages, as they appear in
#guard_msgsoutputs.