chore: use getElem in RHS of getElem theorems #7187
Merged
+25
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moved the RHS of getELem theorems to use getElem. This is a cleanup after the recent move to getElem as simp normal form.
tobiasgrosser
commented
Feb 22, 2025
src/Std/Tactic/BVDecide/Bitblast/BVExpr/Circuit/Lemmas/Expr.lean
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
|
review-requested |
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 25, 2025
This PR moves the RHS of getElem theorems to use getElem. This is a cleanup after the recent move to getElem as simp normal form. We also turn `((!decide (i < n)) && getLsbD x (i - n))` into `if h' : i < n then false else x[i - n]` to preserve the bounds, but keep the decide if the dependent if is not needed to maintain a getElem on the RHS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the RHS of getElem theorems to use getElem. This is a cleanup after the recent move to getElem as simp normal form.
We also turn
((!decide (i < n)) && getLsbD x (i - n))intoif h' : i < n then false else x[i - n]to preserve the bounds, but keep the decide if the dependent if is not needed to maintain a getElem on the RHS.