Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: additional newline before 'additional diagnostic information' message #7169

Merged
merged 3 commits into from
Feb 23, 2025
Merged

chore: additional newline before 'additional diagnostic information' message #7169

merged 3 commits into from
Feb 23, 2025

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Feb 20, 2025

This PR adds an addition newline before the "Additional diagnostic information may be available using the set_option ... true command." messages, to provide better visual separation from the main error message.

@kim-em kim-em requested review from kmill and jrr6 February 20, 2025 21:16
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 20, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a3a99d387564d67a495f14dbac3c02eebeed44b8 --onto 2960b384af1f29f566f59a3ede8ac982e4628f19. (2025-02-20 21:35:48)

kmill
kmill approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@kmill kmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

It would be good though to review all uses of it for messages that insert a newline of their own.

jrr6
jrr6 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@jrr6 jrr6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well.

@kim-em kim-em enabled auto-merge February 21, 2025 05:11
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 23, 2025 23:17 Inactive
@kim-em kim-em added this pull request to the merge queue Feb 23, 2025
Merged via the queue into master with commit da32bdd Feb 23, 2025
15 checks passed
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 24, 2025
@kim-em @luisacicolini
chore: additional newline before 'additional diagnostic information' …
e0ec533 
…message (leanprover#7169)

This PR adds an addition newline before the "Additional diagnostic
information may be available using the `set_option ... true` command."
messages, to provide better visual separation from the main error
message.
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 25, 2025
@kim-em @luisacicolini
chore: additional newline before 'additional diagnostic information' …
6293d3d 
…message (leanprover#7169)

This PR adds an addition newline before the "Additional diagnostic
information may be available using the `set_option ... true` command."
messages, to provide better visual separation from the main error
message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmill kmill kmill approved these changes

@jrr6 jrr6 jrr6 approved these changes

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kim-em @leanprover-community-bot @kmill @jrr6