Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add internal linter for List/Array/Vector variable names #6966

Merged
merged 8 commits into from
Feb 6, 2025
Merged

feat: add internal linter for List/Array/Vector variable names #6966

merged 8 commits into from
Feb 6, 2025

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Feb 6, 2025

This PR adds an internal-use-only strict linter for the variable names of List/Array/Vector variables, and begins cleaning up.

@kim-em kim-em added the changelog-library Library label Feb 6, 2025
@kim-em kim-em requested a review from mhuisi as a code owner February 6, 2025 04:26
@kim-em kim-em enabled auto-merge February 6, 2025 04:26
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 6, 2025 04:37 Inactive
@kim-em kim-em added this pull request to the merge queue Feb 6, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 6, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase de99c8015a547bcd8baa91852970a2e15cda2abf --onto 1f956ad1af1cf423ad68f3ddc294fd2b7e5117df. (2025-02-06 04:52:10)

Merged via the queue into master with commit fd4599f Feb 6, 2025
18 checks passed
tobiasgrosser pushed a commit to opencompl/lean4 that referenced this pull request Feb 16, 2025
@kim-em @tobiasgrosser
feat: add internal linter for List/Array/Vector variable names (leanp…
f458b99 
…rover#6966)

This PR adds an internal-use-only strict linter for the variable names
of `List`/`Array`/`Vector` variables, and begins cleaning up.
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 24, 2025
@kim-em @luisacicolini
feat: add internal linter for List/Array/Vector variable names (leanp…
b3c2cbe 
…rover#6966)

This PR adds an internal-use-only strict linter for the variable names
of `List`/`Array`/`Vector` variables, and begins cleaning up.
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 25, 2025
@kim-em @luisacicolini
feat: add internal linter for List/Array/Vector variable names (leanp…
1c83604 
…rover#6966)

This PR adds an internal-use-only strict linter for the variable names
of `List`/`Array`/`Vector` variables, and begins cleaning up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhuisi mhuisi Awaiting requested review from mhuisi mhuisi is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot