Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix variable names in List lemmas #6953

Merged
merged 8 commits into from
Feb 5, 2025
Merged

chore: fix variable names in List lemmas #6953

merged 8 commits into from
Feb 5, 2025

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Feb 5, 2025

This PR starts on the process of cleaning up variable names across List/Array/Vector. For now, we just rename "numerical index" variables in one file. This is driven by a custom linter.

@kim-em kim-em requested a review from mhuisi as a code owner February 5, 2025 02:37
@kim-em kim-em enabled auto-merge February 5, 2025 02:38
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 5, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase ebba1e04d06ad4b0ad7342aab031a08fe9682394 --onto 412389f71f8a24307e3adba69b38b4b685b04f72. (2025-02-05 03:26:12)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 5, 2025 03:33 Inactive
@kim-em kim-em added this pull request to the merge queue Feb 5, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
This PR starts on the process of cleaning up variable names across
List/Array/Vector. For now, we just rename "numerical index" variables
in one file. This is driven by a custom linter.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@kim-em kim-em added the merge-ci Enable merge queue CI checks for PR. In particular, produce artifacts for all major platforms. label Feb 5, 2025
@kim-em kim-em requested a review from TwoFX as a code owner February 5, 2025 05:09
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 5, 2025 05:16 Inactive
@kim-em kim-em added this pull request to the merge queue Feb 5, 2025
Merged via the queue into master with commit 53ed233 Feb 5, 2025
16 checks passed
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 24, 2025
This PR starts on the process of cleaning up variable names across
List/Array/Vector. For now, we just rename "numerical index" variables
in one file. This is driven by a custom linter.
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 25, 2025
This PR starts on the process of cleaning up variable names across
List/Array/Vector. For now, we just rename "numerical index" variables
in one file. This is driven by a custom linter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-ci Enable merge queue CI checks for PR. In particular, produce artifacts for all major platforms. toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants