Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generalize the bv_normalize pipeline to support more general preprocessing passes #5568

Merged
merged 2 commits into from
Oct 1, 2024
Merged

feat: generalize the bv_normalize pipeline to support more general preprocessing passes #5568

merged 2 commits into from
Oct 1, 2024

Conversation

hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Oct 1, 2024

Beyond what's in the title this also fixes: #5543

@hargoniX
fix: bv_normalize returns the normalized goal if not solved
1d22c11
@hargoniX
feat: generalize bv_normalize to a general pipeline
35abc1b 
In the future we are going to add more preprocessing steps such as ac_nf
and other things that Bitwuzla does. Generalizing to a fixpoint pipeline
seems sensible for such an application.
@hargoniX hargoniX enabled auto-merge October 1, 2024 15:11
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 1, 2024 15:23 Inactive
@hargoniX hargoniX added this pull request to the merge queue Oct 1, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 1, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d0ee9d012774d4343ca2078b19adb11b10940fe0 --onto 5e8718dff9d7906e1d4ca7020256dae7c05e49c2. (2024-10-01 15:34:00)

Merged via the queue into master with commit 863e9c0 Oct 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bv_normalize produces a proof with metavars that cannot be checked by the kernel
2 participants
@hargoniX @leanprover-community-bot