Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add LawCommIdentity + IdempotentOp for BitVec.[and|or|xor] #5416

Merged
merged 3 commits into from
Sep 24, 2024
Merged

feat: add LawCommIdentity + IdempotentOp for BitVec.[and|or|xor] #5416

merged 3 commits into from
Sep 24, 2024

Conversation

tobiasgrosser
Copy link
Contributor

@tobiasgrosser tobiasgrosser commented Sep 22, 2024 •
edited
Loading

As these instances seemingly require explicit arguments, this PR also makes some arguments explicit.

@tobiasgrosser
feat: add LawCommIdentity + IdempotentOp for BitVec.[and|or|xor]
a6c46b2 
As these instances seemingly require explicit, this PR also makes
some arguments explicit.
@tobiasgrosser
Copy link
Contributor Author

I feel we really need to understand better under which conditions arguments should be explicit or implicit and then should standardize this across the BitVec library.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 22, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase fc5201584166e35fadb7d0fe2bd2b8b59450b155 --onto a6830f90ab365e14ccb7ca31201de37f8c1e978c. (2024-09-22 11:40:50)

@kim-em kim-em added the awaiting-author Waiting for PR author to address issues label Sep 23, 2024
@tobiasgrosser
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added awaiting-review Waiting for someone to review the PR and removed awaiting-author Waiting for PR author to address issues labels Sep 23, 2024
@kim-em kim-em added this pull request to the merge queue Sep 24, 2024
Merged via the queue into leanprover:master with commit 3190be3 Sep 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em kim-em left review comments

Assignees
No one assigned
Labels
awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasgrosser @leanprover-community-mathlib4-bot @kim-em