feat: add bv_decide normalization rules for ofBool (a.getLsbD i) and ofBool a[i]
#5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ool (a.getLsbD i)` and `ofBool a[i]`
alexkeizer
changed the title
bv_decide normalization rulesfor ofBool (a.getLsbD i) and ofBool a[i]bv_decide normalization rules for ofBool (a.getLsbD i) and ofBool a[i]
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
hargoniX
reviewed
Sep 17, 2024
shigoel
pushed a commit
to leanprover/LNSym
that referenced
this pull request
Sep 17, 2024
### Description: I've opened [#5375](leanprover/lean4#5375) upstream, but in the meantime we can add the normalization rule ourselves. This ensures we don't have to get rid of uses of the `ofBool (getLsb ..)` pattern in #159 ### Testing: What tests have been run? Did `make all` succeed for your changes? Was conformance testing successful on an Aarch64 machine? Yes ### License: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
@hargoniX addressed your comments, another round of review please! |
hargoniX
approved these changes
Sep 18, 2024
shigoel
pushed a commit
to leanprover/LNSym
that referenced
this pull request
Sep 20, 2024
### Description: I've opened [#5375](leanprover/lean4#5375) upstream, but in the meantime we can add the normalization rule ourselves. This ensures we don't have to get rid of uses of the `ofBool (getLsb ..)` pattern in #159 ### Testing: What tests have been run? Did `make all` succeed for your changes? Was conformance testing successful on an Aarch64 machine? Yes ### License: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LNSym we often use the pattern
ofBool (a.getLsbD i)to pick out a specific bit (i) from a bitvector (a).By adding a rewrite to
extractLsbtobv_decides normalization set, we can still automatically close goals that have this pattern. In the process, I also added a simp-lemma about the value of aFin 1.