Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Syntax.unsetTrailing #5170

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: Syntax.unsetTrailing #5170

merged 1 commit into from
Aug 26, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Aug 26, 2024 •
edited
Loading

Fixes #4958

@Kha
Copy link
Member Author

Kha commented Aug 26, 2024 •
edited
Loading

We should figure out a way to test import requests

@Kha Kha enabled auto-merge August 26, 2024 07:49
@Kha Kha added this pull request to the merge queue Aug 26, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 26, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9305049f1ef7309842806c2a994a2020bb32a71f --onto cee84286e6a6c2716aac8ddcdb552e830f760033. (2024-08-26 07:59:16)

Merged via the queue into leanprover:master with commit dcdbb9b Aug 26, 2024
16 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
@Kha @github-actions
fix: Syntax.unsetTrailing (#5170)
a62fc0e 
Fixes #4958

(cherry picked from commit dcdbb9b)
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Merged
tobiasgrosser pushed a commit to opencompl/lean4 that referenced this pull request Aug 26, 2024
@Kha @tobiasgrosser
fix: Syntax.unsetTrailing (leanprover#5170)
167a9d5 
Fixes leanprover#4958
Kha added a commit that referenced this pull request Aug 26, 2024
@Kha
fix: Syntax.unsetTrailing (#5170)
d017635 
Fixes #4958

(cherry picked from commit dcdbb9b)
@nomeata nomeata mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport releases/v4.11.0 toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go to definition on import doesn't work on last module name
2 participants
@Kha @leanprover-community-mathlib4-bot