Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conv => arg n to handle .subsingletonInst #5149

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: conv => arg n to handle .subsingletonInst #5149

merged 2 commits into from
Aug 29, 2024

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Aug 24, 2024

this fixes #4394, see there for an analysis.

@nomeata
fix: conv => arg n to handle .subsingletonInst well
00522a1 
this fixes #4394, see there for an analysis.
@nomeata nomeata changed the title fix: conv => arg n to handle .subsingletonInst well fix: conv => arg n to handle .subsingletonInst Aug 24, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 24, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 24, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5149
71d8f26
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 24, 2024 11:36 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 24, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5149
ba17cae
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 24, 2024 11:53 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 24, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5149
cb37c67
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 24, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5149
6927a29
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

@nomeata nomeata added the will-merge-soon …unless someone speaks up label Aug 25, 2024
@nomeata nomeata marked this pull request as ready for review August 25, 2024 15:15
@nomeata nomeata requested a review from kim-em as a code owner August 25, 2024 15:15
@nomeata
Copy link
Collaborator Author

nomeata commented Aug 25, 2024

While it’s a bit fishy for non-conv-goals to come out of a conv tactic, this isn't the fault of arg n (it already comes out of congr that way), and it’s ceratinly better leave the goal there than to try .refl if it can’t work. So while this might not solve everything in this corner of the system, it’s likely an improvement. Will let it sit for a bit in case someone cares and has thoughts, and else merge.

@nomeata nomeata added this pull request to the merge queue Aug 29, 2024
Merged via the queue into master with commit aa3c87b Aug 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conv’s arg fails with subsingleton parameters
2 participants
@nomeata @leanprover-community-mathlib4-bot