feat: @[app_delab]
#4976
Merged
feat: @[app_delab]
#4976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `@[app_delab ident]` as a macro for `@[delab app.ident]`. Resolves the identifier when expanding the macro, saving needing to use fully qualified identifiers with `@[delab]`. Also, unlike `@[delab]`, throws an error if the identifier cannot be resolved. Closes leanprover#4899
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
#4976 moved resolution of a promise to an earlier point, but that led to object being marked MT earlier, so we need to move the code that minimizes those objects earlier too to revert the performance regression.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
In #4976, I forgot that we do need info trees eventually on the cmdline for .ilean generation. Unfortunately, not reporting them incrementally would require an API change, so let's see what the impact of incremental reporting is
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 28, 2024
This has the same behavior as `delab app.`, but protects against typos. The feature appeared in leanprover/lean4#4976, though won't be documented until leanprover/lean4#6450.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
@[app_delab ident]as a macro for@[delab app.ident]. Resolves the identifier when expanding the macro, saving needing to use the fully qualified identifiers that@[delab]requires. Also, unlike@[delab], throws an error if the identifier cannot be resolved.Closes #4899