Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate Lean.HashMap and Lean.HashSet #4954

Merged
merged 2 commits into from
Aug 8, 2024
Merged

chore: deprecate Lean.HashMap and Lean.HashSet #4954

merged 2 commits into from
Aug 8, 2024

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Aug 8, 2024 •
edited
Loading

This restores all of the imports of Lean.Data.HashMap and Lean.Data.HashSet so that users actually see the deprecation warnings instead of a "declaration not found" error.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 8, 2024 09:46 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 8, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Aug 8, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-08-08 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-08-08 09:58:06)
  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-08-08 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-08-08 12:46:55)

@TwoFX TwoFX requested review from leodemoura and tydeu as code owners August 8, 2024 12:31
@TwoFX TwoFX enabled auto-merge August 8, 2024 12:33
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 8, 2024 12:40 Inactive
@TwoFX TwoFX added this pull request to the merge queue Aug 8, 2024
Merged via the queue into master with commit b144107 Aug 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoFX @leanprover-community-mathlib4-bot