Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unflakify test cases #4940

Merged
merged 1 commit into from
Aug 7, 2024
Merged

test: unflakify test cases #4940

merged 1 commit into from
Aug 7, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Aug 7, 2024

With the recent unification of server and cmdline processing, IO.Process tests that previously broke the server because they directly wrote to stdout are now flaky on the cmdline because elaboration and reporting are happening in separate threads. By removing direct writes to stdout, the race condition is removed and the file can actually be edited in the language server as well again.

@Kha Kha enabled auto-merge August 7, 2024 08:19
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 7, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 574066b30b32ed9742042706b59ea0c12d0541d8 --onto 647a5e94925791f6a16b629b6c16ffad60a7f478. (2024-08-07 08:36:18)

@Kha Kha added this pull request to the merge queue Aug 7, 2024
Merged via the queue into leanprover:master with commit 1efd665 Aug 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants