-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: infer mutual structural recursion #4718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf3d547
to
ede15f5
Compare
Mathlib CI status (docs):
|
152260d
to
c08f133
Compare
Co-authored-by: Tobias Grosser <[email protected]>
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 12, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 12, 2024
This adds the types * `IndGroupInfo`, a variant of `InductiveVal` with information that applies to a whole group of mutual inductives and * `IndGroupInst` which extends `IndGroupInfo` with levels and parameters to indicate a instantiation of the group. One purpose of this abstraction is to make it clear when a fuction operates on a group as a whole, rather than a specific inductive within the group. This is extracted from #4718 and #4733 to reduce PR size and improve bisectability.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 13, 2024
This adds the types * `IndGroupInfo`, a variant of `InductiveVal` with information that applies to a whole group of mutual inductives and * `IndGroupInst` which extends `IndGroupInfo` with levels and parameters to indicate a instantiation of the group. One purpose of this abstraction is to make it clear when a fuction operates on a group as a whole, rather than a specific inductive within the group. This is extracted from #4718 and #4733 to reduce PR size and improve bisectability.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
This now works: ```lean inductive Tree where | node : List Tree → Tree mutual def Tree.size : Tree → Nat | node ts => list_size ts def Tree.list_size : List Tree → Nat | [] => 0 | t::ts => t.size + list_size ts end ``` It is still out of scope to expect to be able to use nested recursion (e.g. through `List.map` or `List.foldl`) here. Depends on #4718. --------- Co-authored-by: Tobias Grosser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the support for mutual structural recursion (new since #4575) is extended so that Lean tries to infer it even without annotations.
termination_by structural
.termination_by structural
on not necessarily all functions of a clique; this simply restricts the combinations of arguments that Lean considers.