-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: calculate error suppression per snapshot #4657
Conversation
Mathlib CI status (docs):
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-releases/v4.9.0 releases/v4.9.0
# Navigate to the new working tree
cd .worktrees/backport-releases/v4.9.0
# Create a new branch
git switch --create backport-4657-to-releases/v4.9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4d2f2d7cc59f1df0417f7b58329cbd3fbd2f0906
# Push it to GitHub
git push --set-upstream origin backport-4657-to-releases/v4.9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-releases/v4.9.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-releases/v4.10.0 releases/v4.10.0
# Navigate to the new working tree
cd .worktrees/backport-releases/v4.10.0
# Create a new branch
git switch --create backport-4657-to-releases/v4.10.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4d2f2d7cc59f1df0417f7b58329cbd3fbd2f0906
# Push it to GitHub
git push --set-upstream origin backport-4657-to-releases/v4.10.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-releases/v4.10.0 Then, create a pull request where the |
Generalizes leanprover#3556 to not suppressing errors in tactic steps either when the parse error is in a later step, as otherwise changes to the end of a proof would affect (correctness or effectiveness of) incrementality of preceding steps. Fixes leanprover#4623, in combination with leanprover#4643
Generalizes #3556 to not suppressing errors in tactic steps either when the parse error is in a later step, as otherwise changes to the end of a proof would affect (correctness or effectiveness of) incrementality of preceding steps.
Fixes #4623, in combination with #4643