Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move @[simp] from pred_le to sub_one_le #4522

Merged
merged 5 commits into from
Jun 23, 2024
Merged

chore: move @[simp] from pred_le to sub_one_le #4522

merged 5 commits into from
Jun 23, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Jun 21, 2024 •
edited
Loading

(We already have a simp lemma unfolding pred to · - 1.)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 21, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 21, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4522
27e0888
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 21, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4522
fd4d783
@kim-em
Copy link
Collaborator Author

kim-em commented Jun 21, 2024

@nomeata, could you assist me on this one? tests/lean/guessLexTricky.lean appears to be the only thing failing, and I can't work out what is going wrong.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 21, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jun 21, 2024 •
edited
Loading

Mathlib CI status (docs):

nomeata
nomeata reviewed Jun 21, 2024
View reviewed changes
src/Init/Data/Nat/Basic.lean Outdated
Comment on lines 285 to 286
@[simp] theorem sub_one_le (n : Nat) : n - 1 ≤ n :=
pred_le n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this lemma subsumed by Nat.sub_le, which could just be made @[simp]?

@nomeata
Copy link
Collaborator

nomeata commented Jun 21, 2024

Pushed a work-around

@nomeata nomeata mentioned this pull request Jun 21, 2024
Closed
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 21, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4522
ce8430d
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 21, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4522
97de544
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 21, 2024 08:18 Inactive
@kim-em kim-em added this pull request to the merge queue Jun 21, 2024
@kim-em kim-em removed this pull request from the merge queue due to a manual request Jun 21, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 21, 2024 10:33 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 21, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4522
418573a
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 21, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4522
5961dea
@kim-em kim-em added this pull request to the merge queue Jun 23, 2024
Merged via the queue into master with commit a92e9c7 Jun 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomeata nomeata nomeata left review comments

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-em @leanprover-community-mathlib4-bot @nomeata