Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: lake: touchup require syntax & docs #4496

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Jun 19, 2024

A set of general tweaks of the require syntax and docs that provide a base for #4495.

The sole significant behavioral change is that the name field of a require in TOML now falls back to being interpreted as a simple string name if the value is not a valid Lean identifier. This means that a require for a package like doc-gen4 can be written without French quotes.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 19, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 19, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 19, 2024
@tydeu tydeu added the will-merge-soon …unless someone speaks up label Jun 19, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 19, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

@tydeu tydeu added this pull request to the merge queue Jun 19, 2024
@tydeu tydeu changed the title refactor: touchup require syntax & docs refactor: lake: touchup require syntax & docs Jun 19, 2024
Merged via the queue into leanprover:master with commit f9952e8 Jun 19, 2024
24 checks passed
@tydeu tydeu deleted the lake/require-touchup branch June 26, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants