refactor: lake: ensure job actions can be lifted to FetchM
#4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 25, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 25, 2024
tydeu
force-pushed
the
lake/logio-build-actions
branch
from
96ed09c to
ef09829
Compare
tydeu
force-pushed
the
lake/logio-build-actions
branch
from
ef09829 to
aba091d
Compare
tydeu
changed the title
LogIO for basic build actionsFetchM
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 25, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 25, 2024
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 25, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 25, 2024
leanprover-community-mathlib4-bot
added
breaks-mathlib
tydeu
added a commit
to tydeu/lean4
that referenced
this pull request
Jun 4, 2024
…ver#4273) In `v4.8.0-rc2`, due to additional build refactor changes, `JobM` no longer cleanly lifts in `FetchM`. Generally, a `JobM` action should not be run `FetchM` directly but spawned asynchronously as job (e.g., via `Job.async`). However, there may be some edge cases were this is necessary and it is a backwards compatibility break, so this change adds back the lift. This change also includes an `example` definition to ensure the lift works in order to prevent similar accidental breakages in the future. This breakage was first reported by Mario on [Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/v4.2E8.2E0-rc2.20discussion/near/440407037).
tydeu
added a commit
that referenced
this pull request
Jun 5, 2024
In `v4.8.0-rc2`, due to additional build refactor changes, `JobM` no longer cleanly lifts in `FetchM`. Generally, a `JobM` action should not be run `FetchM` directly but spawned asynchronously as job (e.g., via `Job.async`). However, there may be some edge cases were this is necessary and it is a backwards compatibility break, so this change adds back the lift. This change also includes an `example` definition to ensure the lift works in order to prevent similar accidental breakages in the future. This breakage was first reported by Mario on [Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/v4.2E8.2E0-rc2.20discussion/near/440407037).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
v4.8.0-rc2, due to additional build refactor changes,JobMno longer cleanly lifts inFetchM. Generally, aJobMaction should not be runFetchMdirectly but spawned asynchronously as job (e.g., viaJob.async). However, there may be some edge cases were this is necessary and it is a backwards compatibility break, so this change adds back the lift. This change also includes anexampledefinition to ensure the lift works in order to prevent similar accidental breakages in the future.This breakage was first reported by Mario on Zulip.