chore: rename Option.toMonad and remove argument #3865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
digama0
reviewed
Apr 10, 2024
src/Init/Data/Option/Basic.lean
Outdated
| | none => failure | ||
| | some a => pure a | ||
|
|
||
| @[deprecated toAlternative] def toMonad [Monad m] [Alternative m] : Option α → m α := |
There was a problem hiding this comment.
Does this really need to be deprecated? Besides being a longer name, the name toMonad is also better for people who don't want to have to think about the various monad variants. (I think we could remove the unneeded argument from it though.)
Maybe a better name would be something like getM though, since this is like Option.get but with a monadic effect for failure.
kim-em
force-pushed
the
Option.toMonad
branch
2 times, most recently
from
2e480dc to
a9bc091
Compare
oops oops
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.