chore: rw? uses MVarId.refl not MVarId.applyRfl #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
force-pushed
the
rw_uses_refl_not_applyRfl
branch
from
a8784a9 to
06f0ea1
Compare
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was in error in my original Mathlib implementation. We're not interested in relations other than
=, so there is no point usingMVarId.applyRfl, which just looks up@[refl]tagged lemmas and tries those.In a separate PR, I will change
MVarId.applyRflso it has a flag to control whether on=it should just hand-off toMVarId.refl, or fail. Failure is appropriate in the version we call from therflmacro, to avoid doing a doubleIsDefEqcheck on everyrfl!