-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bool and prop lemmas for Mathlib compatibility and improved confluence #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathlib CI status (docs):
|
0f2ccb7
to
255c9cb
Compare
kim-em
reviewed
Feb 29, 2024
kim-em
reviewed
Feb 29, 2024
kim-em
reviewed
Feb 29, 2024
kim-em
reviewed
Feb 29, 2024
kim-em
reviewed
Feb 29, 2024
kim-em
reviewed
Feb 29, 2024
kim-em
reviewed
Feb 29, 2024
This is a major refactor of the Bool/Prop simp tester to support other theories and support non-linear test cases. As part of this, additional lemmas were added to improve confluence.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
I think these were dropped in #3508, and Mathlib needs them.
tydeu
pushed a commit
to tydeu/lean4
that referenced
this pull request
Mar 11, 2024
I think these were dropped in leanprover#3508, and Mathlib needs them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a number of lemmas for simplification of
Bool
andProp
terms. It pulls lemmas from Mathlib and adds additional lemmas where confluence or consistency suggested they are needed.It has been tested against Mathlib using some automated test infrastructure.
That testing module is not yet included in this PR, but will be included as part of this.
Note. There are currently some comments saying the origin of the simp rule. These will be removed prior to merging, but are added to clarify where the rule came from during review.