Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bool and prop lemmas for Mathlib compatibility and improved confluence #3508

Merged
merged 18 commits into from
Mar 5, 2024

Conversation

joehendrix
Copy link
Contributor

@joehendrix joehendrix commented Feb 26, 2024

This adds a number of lemmas for simplification of Bool and Prop terms. It pulls lemmas from Mathlib and adds additional lemmas where confluence or consistency suggested they are needed.

It has been tested against Mathlib using some automated test infrastructure.

That testing module is not yet included in this PR, but will be included as part of this.

Note. There are currently some comments saying the origin of the simp rule. These will be removed prior to merging, but are added to clarify where the rule came from during review.

@joehendrix joehendrix added the WIP This is work in progress, and only a PR for the sake of CI or sharing. No review yet. label Feb 26, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 26, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Feb 26, 2024

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e73495e5a6059bfebeed65032fed2b9a1b6933c9 --onto 88fbe2e5313bb418abdb035c48cae2680ea9bcea. (2024-02-26 19:59:43)
  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 755de48ff318dcf370037c969374148dc56d458e --onto a23292f0491c7373bd6ec4ca44d030ded15d1719. (2024-02-29 05:31:13)
  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 7e944c1a309728581257cb6351c9bc0b9c741b7e --onto 43d6eb144e7a84af7c6eb40e60c9d2538367d6eb. (2024-03-01 17:12:53)
  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e814fc859e8feb2c7e1c94a1d8b05e8b27149e62 --onto e6d6855a854cbde5bf7d99c7997443427dcfdba9. (2024-03-04 22:22:45)

@joehendrix joehendrix changed the title Bool and prop lemmas for Mathlib compatibility and improved confluence chore: bool and prop lemmas for Mathlib compatibility and improved confluence Feb 26, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 28, 2024 16:50 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 29, 2024 05:28 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 29, 2024 06:37 Inactive
@joehendrix joehendrix removed the WIP This is work in progress, and only a PR for the sake of CI or sharing. No review yet. label Feb 29, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 29, 2024 07:21 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 29, 2024 16:43 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 29, 2024 17:01 Inactive
@joehendrix joehendrix added this pull request to the merge queue Feb 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 1, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 1, 2024 17:08 Inactive
@joehendrix joehendrix added this pull request to the merge queue Mar 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 1, 2024
@kim-em kim-em added this pull request to the merge queue Mar 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 4, 2024
This is a major refactor of the Bool/Prop simp tester to support other
theories and support non-linear test cases.  As part of this, additional
lemmas were added to improve confluence.
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 4, 2024 23:54 Inactive
@joehendrix joehendrix added this pull request to the merge queue Mar 4, 2024
Merged via the queue into master with commit 01104cc Mar 5, 2024
11 checks passed
@joehendrix joehendrix deleted the bool_norm branch March 5, 2024 00:34
@joehendrix joehendrix restored the bool_norm branch March 5, 2024 00:34
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2024
I think these were dropped in #3508, and Mathlib needs them.
tydeu pushed a commit to tydeu/lean4 that referenced this pull request Mar 11, 2024
I think these were dropped in leanprover#3508, and Mathlib needs them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants