Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tests for #2966 to use test_extern #3092

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Dec 19, 2023

#2966 was the @[extern] bug that prompted development of the test_extern command, but then we merged the fix to #2966 without updating the tests to use test_extern.

@kim-em kim-em added the awaiting-review Waiting for someone to review the PR label Dec 19, 2023
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 19, 2023
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 19, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 19, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Dec 19, 2023

leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 19, 2023
@kim-em kim-em added this pull request to the merge queue Dec 21, 2023
Merged via the queue into master with commit bcc49d1 Dec 21, 2023
@nomeata nomeata deleted the 2966_test_extern branch December 22, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Waiting for someone to review the PR builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants