Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: upstream LeanSAT's bitblaster (#5013)
Step 3/~7 in upstreaming LeanSAT. A few thoughts: - Why is this not in `Std.Sat`? LeanSAT's bitblaster operates on a limited internal language. For example it has no idea that signed comparision operators even exist. This is because it relies on a normalization pass before being given the goal. For this reason I would not classify the bitblaster as an API that we should publicly advertise at this abstraction level - Sometimes I slightly rebuild parts of the LawfulOperator infrastructure for operators that work non-tail-recursively. This is because they do not return an `Entrypoint` but instead an `ExtendingEntrypoint` in order to even be defined in the first place (casting Ref's and all that). Given the fact that this barely happens and I never actually commit to rebuilding the full API I'm hoping that this is indeed a fine decision? - The single explicit `decreasing_by` that has a simp only which *almost* looks like `simp_wf` is missing a singular lemma from `simp_wf` because it doesn't terminate otherwise. - I am not using functional induction because it basically always fails at some generalization step, that is also the reason that there is lots of explicit `generalize` and manually recursive proofs. --------- Co-authored-by: Markus Himmel <[email protected]> Co-authored-by: Tobias Grosser <[email protected]>
- Loading branch information