-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable lake build
#30
Comments
In all the use cases I have encountered it works well to simply include the step: - name: Install elan
run: |
curl https://raw.githubusercontent.com/leanprover/elan/master/elan-init.sh -sSf | sh -s -- -y
echo "$HOME/.elan/bin" >> $GITHUB_PATH Do you have something in mind where it would be better to use |
It is an advantage to be able to provide standard commands to install elan. |
For example, I often see elan installed with commands such as run: |
curl -sSfL https://raw.githubusercontent.com/leanprover/elan/master/elan-init.sh | sh -s -- -y --default-toolchain none
echo "$USERPROFILE\.elan\bin" >> $GITHUB_PATH |
|
Documentation for the possible arguments for Concerning the path, there are various ways that work, the prior one is the suggested way. |
As we expand the inputs to support more use cases, we may want to consider changing the behavior of the inputs so that all the steps are disabled by default and you specify what you want when you call the action. This style is inspired by python-action. For example, - uses: leanprover/lean-action
with:
build: true
test: true
lint: true The current behavior is a set of steps which are enabled by default ( Note we could still provide a sensible default configuration either when the action is called with no inputs or with a - uses: leanprover/lean-action
with:
default: true |
I ran into a use case for this today while adding some automated functional testing. link |
`auto-config` allows users to specify if `lean-action` should use the Lake workspace to automatically decide which CI features to run. `build` allows users to specify if `lean-action` runs `lake build`. By default, `auto-config: true`. The `test` and `build` (and soon `lint`, see #46) inputs allow users to override the automatically configured behavior or configure `lean-action` when `auto-config: false`. `auto-config: true` is close to the previous default behavior, however there is a difference in the outcome of the `lake test` step. When users set `test: true` manually, `lean-action` must find tests with `lake check-test` and run `lake test` or it will fail (this was the previous behavior). However with `auto-config: true`, if `lake check-test` fails, `lean-action` will not run `lake test` and this won't cause `lean-action` to fail. Closes #60, #53, and #30.
Closed by #61 |
I sometimes want just to install
elan
and not to runlake build
The text was updated successfully, but these errors were encountered: