This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
chore: don't rely on simp calling decide #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this fails here, then we're probably missing a |
Ah, good point. I will go hunting. |
|
Kha
pushed a commit
to Kha/lean4
that referenced
this pull request
Jul 17, 2023
Kha
pushed a commit
to Kha/lean4
that referenced
this pull request
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to change the default behaviour in
simpfrom{ decide := true }to{ decide := false }.See
I think I've got all the patches to Lean4 required, except that I need to make a simultaneous change to
lakein order to pass CI! (Oh what a tangled web we weave...)This simple PR makes Lake agnostic to the default behaviour in Lean, compiling successfully either before or after the change. If it is okay to merge this, then hopefully I can proceed with the rest.